Re: [Bug-wget] Re: Steven Schweda's VMS patch in mainline

[Steven M. Schweda]

From: Keisial [...]

> Steven, note that all those headers are .h.in files, but have no m4
> variables, so just copying them to the .h name works.

   Yup.  I'm (slowly) waking up.  I've been away from this stuff for too
long.  (And my brain is old and tired.  (And I'm lazy.))

   The VMS builders are complicated by the fact that a file name like
"xxx.h.in" is too exotic for an ODS2 file system, and whether it gets
stored as "XXX.H_IN" or "XXX_H.IN" (or who knows what else) depends on
who unpacks the source kit.  I intend to try to find an auto-sensing
scheme to cope with the more likely possibilities, but it'll be a while. 
Everything's complicated.

   I am making a little progress, however.  I'm reorganizing the VMS
builders to deal with the more complex source tree structure.  Not done,
but I did get far enough to get to an interesting run-time message
problem.  Don't know if it's been noticed and/or fixed already, but:

ALP $ wgxl --no-check-certificate https://alp-l
--2009-09-21 23:24:34--  https://alp-l/
Resolving alp-l... 10.0.0.9
Connecting to alp-l|10.0.0.9|:443... connected.
WARNING: cannot verify `/C=US/ST=MN/L=Saint Paul/O=Antinode/CN=antinode.info/ema
address@hidden''s certificate, issued by `/C=US/ST=MN/L=Saint
 Paul/O=Antinode/CN=antinode.info/address@hidden':
  Self-signed certificate encountered.
WARNING: certificate common name `alp-l' doesn't match requested host name `alp-
l'.
HTTP request sent, awaiting response... 200 OK
Length: 1009 [text/html]
Saving to: `index.html'

100%[======================================>] 1,009       --.-K/s   in 0s

2009-09-21 23:24:35 (19.7 KB/s) - `index.html' saved [1009/1009]


I thought that "certificate common name `alp-l'" matched "requested host
name `alp-l'" pretty well, but it's the result of a misleading message. 
Actually, as a diagnostic printf() revealed:
      common_name: >antinode.info<, host: >alp-l<.

I know nothing, but in src/openssl.c, this puts out the meassage:

      logprintf (LOG_NOTQUIET, _("\
%s: certificate common name %s doesn't match requested host name %s.\n"),
                 severity, quote (common_name), quote (host));

and I'm guessing that the fancy quote() function is insufficiently
fancy, and is using the same buffer for both invocations in that
statement, so the second name ("host: >alp-l<") appears in both places.
Should someone be auto-incrementing (modulo something) an "n" somewhere?

------------------------------------------------------------------------

   Steven M. Schweda               address@hidden
   382 South Warwick Street        (+1) 651-699-9818
   Saint Paul  MN  55105-2547