bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] bug #20389 - patch


From: Keisial
Subject: Re: [Bug-wget] bug #20389 - patch
Date: Sun, 14 Mar 2010 01:04:35 +0100
User-agent: Thunderbird

Marco Oliva wrote:

 http://savannah.gnu.org/bugs/?20389


 --- utils.c.orig       2010-03-04 21:09:31.000000000 +0000
 +++ utils.c    2010-03-13 16:09:42.000000000 +0000
 @@ -535,12 +535,12 @@
   bool
   file_exists_p (const char *filename)
   {
 -#ifdef HAVE_ACCESS
 -  return access (filename, F_OK)>= 0;
 -#else
 -  struct_stat buf;
 -  return stat (filename,&buf)>= 0;
 -#endif
 +  if (true)
 +    return access (filename, F_OK)>= 0;
 +
 +  else
 +    struct_stat buf;
 +    return stat (filename,&buf)>= 0;
   }

   /* Returns 0 if PATH is a directory, 1 otherwise (any kind of file).


The HAVE_ACCESS check was so it can compile in systems without access(2).
Your patch makes it illegal C, so it won't compile in any system.

I think you haven't understood what bug 20389 is about.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]