Re: [Bug-wget] contributing to wget

[Giuseppe Scrivano]

Hello,

thanks for your contribution.


I have some comments:

"address@hidden" <address@hidden> writes:

> Thanks for the encouragement! I've attached a patch which should tell
> the user there is a problem with the system wgetrc file and exit. Seems
> suspiciously simple, can anyone spot any problems with it? 
>
> Reza Snowdon

> --- wget_clean/wget/src/init.c        2010-06-11 00:31:32.000000000 +0100
> +++ wget/src/init.c   2010-06-11 00:32:37.000000000 +0100
> @@ -526,7 +526,8 @@
>    ln = 1;
>    while ((line = read_whole_line (fp)) != NULL)
>      {
> -      char *com = NULL, *val = NULL;
> +  
> +    char *com = NULL, *val = NULL;

I don't think you want really to break the sexy GNU indentation here.



> +  if (!ok) 
> +    {
> +     fprintf(stderr, _("Parsing system wgetrc file failed; please check 
> '%s'.\n"), SYSTEM_WGETRC);
> +     exit(2);
> +    }                

Please leave an empty space between the function name and '(',
e.g., "fprintf (..." and break that long line to 80 columns.

Please change the type of the variable `ok' to `bool' and include this
change in your patch, also include <stdbool.h>.

As last thing, please provide a ChangeLog entry (src/ChangeLog) and a
NEWS file entry.

Cheers,
Giuseppe