bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Bug in processing url query arguments that have '/'


From: Giuseppe Scrivano
Subject: Re: [Bug-wget] Bug in processing url query arguments that have '/'
Date: Mon, 08 Aug 2011 14:54:55 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Peng Yu <address@hidden> writes:

> I was looking at the patched version. (See the patch posted in bug
> #31147) So I think that the bug in the patch (see the relevant code
> below, where full_file has the query string). I guess for full_file a
> different 'acceptable' function should be used.
>
>   if (opt.match_query_string) full_file = concat_strings(u->file, "?",
> u->query, (char *) 0);
>
>   if (!acceptable (full_file))
>     {
>     DEBUGP (("%s (%s) does not match acc/rej rules.\n",
>           url, full_file));
>     goto out;
>     }
>   }

I am inclined to don't add more options to the current Accept/Reject
rules, as I think they are not flexible enough and quite tricky.

It is better to support a more generic way to specify these rules.

Cheers,
Giuseppe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]