bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Wget 1.13.4 v. VMS -- Various problems


From: Steven M. Schweda
Subject: Re: [Bug-wget] Wget 1.13.4 v. VMS -- Various problems
Date: Thu, 29 Sep 2011 17:10:11 -0500 (CDT)

>    I still have some VMS-specific builder changes to make, but the
> changes to "src/connect.c", "src/log.c", and "src/main.c" seem to be all
> that I've needed in the common code (so far).  [...]

   Well, not quite.  In "src/openssl.c:ssl_init()", there's this:

  SSL_METHOD const *meth;

which causes a problem with some older OpenSSL kits (0.9.8j, for
example), where the argument to SSL_CTX_new() was not declared as
"const" (as it is in a newer OpenSSL kit, like, say, 1.0.0e):

CC /float = ieee_float  /include = ([], [.ALPHAL],  [-.LIB], [-.LIB.ALPHAL], [-.
VMS])   /prefix_library_entries =  (all_entries, except = (utime , __UTC_UTIME))
    /object = [.ALPHAL]OPENSSL.OBJ /define = (VMS, _POSIX_EXIT  , "ENABLE_DEBUG"
 , "_LARGEFILE" , "HAVE_SSL", "ENABLE_NTLM"  ) [-.SRC]OPENSSL.C

  ssl_ctx = SSL_CTX_new (meth);
.........................^
%CC-W-NOTCONSTQUAL, In this statement, the referenced type of the pointer value
"meth" is const, but the referenced type of the target of this assignment is not
.
at line number 204 in file ALP2$DKC0:[utility.source.WGET.wget-1_13_4.src]openss
l.c;1

Naturally, the latest HP-supplied SSL kit is based on some 0.9.8 kit, so
this would likely affect more users than one might expect.  I don't know
what the preferred solution would be.  Adding a type cast seems to fix
the problem here:

ALP $ gdiff -u src/openssl.c_orig src/openssl.c
--- src/openssl.c_orig  2011-08-29 03:01:24 -0500
+++ src/openssl.c       2011-09-29 17:40:09 -0500
@@ -201,7 +201,9 @@
       abort ();
     }

-  ssl_ctx = SSL_CTX_new (meth);
+  /* The type cast below accomodates older OpenSSL versions (0.9.8)
+     where SSL_CTX_new() is declared without a "const" argument. */
+  ssl_ctx = SSL_CTX_new ((SSL_METHOD *)meth);
   if (!ssl_ctx)
     goto error;

but I haven't tried it in any other environments.


   And there's still that error message in "src/init.c" which uses
SYSTEM_WGETRC, whether or not SYSTEM_WGETRC is defined.

------------------------------------------------------------------------

   Steven M. Schweda               address@hidden
   382 South Warwick Street        (+1) 651-699-9818
   Saint Paul  MN  55105-2547



reply via email to

[Prev in Thread] Current Thread [Next in Thread]