Re: [Bug-wget] Wget 1.13.4 v. VMS -- Various problems

[Steven M. Schweda]

From: Giuseppe Scrivano <address@hidden>

> >       http://antinode.info/ftp/wget/wget-1_13_4/1_13_4_1.dru

> can you please include a ChangeLog entry for each of them?

--- ChangeLog._orig     2011-09-13 03:08:59 -0500
+++ ChangeLog.  2011-10-07 14:29:59 -0500
@@ -1,3 +1,38 @@
+2011-10-07  Steven Schweda  <address@hidden>
+
+       * connect.c: Add HAVE_SYS_SELECT_H and HAVE_SYS_SOCKET_H conditions
+       on includes of <sys/select.h> and <sys/socket.h>, respectively.
+
+       * ftp.c (getftp): Move BIN_TYPE_TRANSFER macro into VMS-specific
+       section.  On VMS, use Stream_LF attributes for listing files.  Pass
+       BIN_TYPE_FILE to fopen_excl() instead of constant-everywhere "true".
+
+       * ftp.c (ftp_retrieve_list): Restore lost test of opt.preserve_perm
+       (--preserve-permissions) on the chmod() operation.
+
+       * init.c, main.c: Remove "deprecated" from opt.preserve_perm
+       (--preserve-permissions).
+
+       * init.c (initialize): Use distinct messages for errors in C macro
+       SYSTEM_WGETRC and environment-variable SYSTEM_WGETRC.  Avoid use of
+       C macro SYSTEM_WGETRC when it's not defined.
+
+       * log.c (log_close): Avoid closing logfp when it's stderr.
+
+       * main.c (print_help):  Restore --preserve-permissions.
+
+       * main.c (main): Avoid using a negative value of longindex as a
+       subscript (for long_options[]) when searching for "--config".
+
+       * main.c (main): Exit the program using exit() instead of "return".
+       (VMS handles these differently, and exit() is better.)
+
+       * openssl.c (ssl_init): Add type cast (SSL_METHOD *) to newly "const"
+       "meth" argument to accommodate OpenSSL version 0.9.8, where that
+       argument is not "const" in the OpenSSL function (SSL_CTX_new).
+
+       * utils.c (fopen_excl): Comment typography.
+
 2011-09-13  Giuseppe Scrivano  <address@hidden>
 
        * ftp.c (ftp_retrieve_glob): Propagate correctly the `res' error


   Note that in openssl.c, "accomodate" should be "accommodate".  (Not
the only place in the code, but this one would be new and my fault.)

   The leading-tab indentation in "src/ChangeLog" seems to have some
exceptions.

   And, of course, there are various changes to the VMS builders and
other accessory files, but I don't know how these will be handled.

------------------------------------------------------------------------

   Steven M. Schweda               address@hidden
   382 South Warwick Street        (+1) 651-699-9818
   Saint Paul  MN  55105-2547