[Bug-wget] Wget regression - now defaults to saving file as original link name instead of correct file name after redirect!

[Richard Rudling]

Hi

 

This is with Cygwin binary of wget running on Windows 7.  Previous behaviour
in 1.12 - after following a server redirect (302 Found -> Location) wget
saves the file using the name from the new location as expected:

> wget -V
GNU Wget 1.12 built on cygwin.

+digest +ipv6 +nls +ntlm +opie +md5/openssl +https -gnutls +openssl
+iri

Wgetrc:
    /etc/wgetrc (system)
Locale: /usr/share/locale
Compile: gcc-4 -DHAVE_CONFIG_H -DSYSTEM_WGETRC="/etc/wgetrc"
    -DLOCALEDIR="/usr/share/locale" -I.
    -I/usr/src/wget-1.12-1/src/wget-1.12/src
    -I/usr/src/wget-1.12-1/src/wget-1.12/lib -O2 -pipe
Link: gcc-4 -O2 -pipe -lssl -lcrypto -liconv -lintl -ldl -lidn ftp-opie.o
    openssl.o http-ntlm.o gen-md5.o ../lib/libgnu.a

Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
< <http://www.gnu.org/licenses/gpl.html>
http://www.gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Originally written by Hrvoje Niksic < <mailto:address@hidden>
address@hidden>.
Currently maintained by Micah Cowan < <mailto:address@hidden>
address@hidden>.
Please send bug reports and questions to < <mailto:address@hidden>
address@hidden>.

 

C:\temp\ms\mbsa
> wget -S -c --no-check-certificate "
<http://go.microsoft.com/fwlink/?LinkId=76054>
http://go.microsoft.com/fwlink/?LinkId=76054";
--2011-12-05 00:22:42--   <http://go.microsoft.com/fwlink/?LinkId=76054>
http://go.microsoft.com/fwlink/?LinkId=76054
Resolving go.microsoft.com (go.microsoft.com)... 65.55.57.251
Connecting to go.microsoft.com (go.microsoft.com)|65.55.57.251|:80...
connected.
HTTP request sent, awaiting response...
  HTTP/1.1 302 Found
  Cache-Control: private
  Content-Type: text/html; charset=utf-8
  Expires: Mon, 05 Dec 2011 00:21:41 GMT
  Location:
<http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab>
http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab
  Server: Microsoft-IIS/7.5
  X-AspNet-Version: 4.0.30319
  X-Powered-By: ASP.NET
  Date: Mon, 05 Dec 2011 00:22:40 GMT
  Connection: keep-alive
  Content-Length: 191
Location:
<http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab>
http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab
[following]
--2011-12-05 00:22:42--
<http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab>
http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab
Resolving download.windowsupdate.com (download.windowsupdate.com)...
217.32.28.42, 217.32.28.8
Connecting to download.windowsupdate.com
(download.windowsupdate.com)|217.32.28.42|:80... connected.
HTTP request sent, awaiting response...
  HTTP/1.0 200 OK
  Content-Type: application/octet-stream
  Last-Modified: Wed, 23 Nov 2011 01:07:07 GMT
  Accept-Ranges: bytes
  ETag: "80af26387ca9cc1:0"
  Server: Microsoft-IIS/7.5
  X-Powered-By: ASP.NET
  Content-Length: 29184228
  Expires: Mon, 05 Dec 2011 00:22:41 GMT
  Pragma: no-cache
  Date: Mon, 05 Dec 2011 00:22:41 GMT
  Connection: keep-alive
  Cache-Control: max-age=0
Length: 29184228 (28M) [application/octet-stream]
Saving to: `wsusscn2.cab'

100%[=======================================================================
=======>] 29,184,228  2.49M/s   in 11s

2011-12-05 00:23:39 (2.45 MB/s) - `wsusscn2.cab' saved [29184228/29184228]


With 1.13.4 - after following a server redirect (302 Found -> Location) wget
saves the file using the 'name' from the original link and in fact even adds
in a spurious index.html = broken!:

> wget -V

GNU Wget 1.13.4 built on cygwin.

+digest +https +ipv6 +iri +large-file +nls -ntlm +opie +ssl/gnutls

Wgetrc:

    /etc/wgetrc (system)

Locale: /usr/share/locale

Compile: gcc-4 -DHAVE_CONFIG_H -DSYSTEM_WGETRC="/etc/wgetrc"

    -DLOCALEDIR="/usr/share/locale" -I.

    -I/usr/src/wget-1.13.4-1/src/wget-1.13.4/src -I../lib

    -I/usr/src/wget-1.13.4-1/src/wget-1.13.4/lib -g -O2 -pipe

Link: gcc-4 -g -O2 -pipe -liconv -lintl /usr/lib/libgnutls.dll.a

    /usr/lib/libtasn1.dll.a /usr/lib/libz.dll.a

    /usr/lib/libgcrypt.dll.a /usr/lib/libgpg-error.dll.a

    /usr/lib/libintl.dll.a -L/usr/lib/ncursesw /usr/lib/libiconv.dll.a

    -lgcrypt -lgpg-error -lz -lidn ftp-opie.o gnutls.o ../lib/libgnu.a

Copyright (C) 2009 Free Software Foundation, Inc.

License GPLv3+: GNU GPL version 3 or later

<http://www.gnu.org/licenses/gpl.html>.

This is free software: you are free to change and redistribute it.

There is NO WARRANTY, to the extent permitted by law.

Originally written by Hrvoje Niksic <address@hidden>.

Please send bug reports and questions to <address@hidden>.

 

> wget -S -c --no-check-certificate
"http://go.microsoft.com/fwlink/?LinkId=76054";

--2011-12-05 00:07:59--  http://go.microsoft.com/fwlink/?LinkId=76054

Resolving go.microsoft.com (go.microsoft.com)... 65.55.57.251

Connecting to go.microsoft.com (go.microsoft.com)|65.55.57.251|:80...
connected.

HTTP request sent, awaiting response...

  HTTP/1.1 302 Found

  Cache-Control: private

  Content-Type: text/html; charset=utf-8

  Expires: Mon, 05 Dec 2011 00:07:00 GMT

  Location:
http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab

  Server: Microsoft-IIS/7.5

  X-AspNet-Version: 4.0.30319

  X-Powered-By: ASP.NET

  Date: Mon, 05 Dec 2011 00:08:00 GMT

  Content-Length: 191

Location:
http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab
[following]

--2011-12-05 00:07:59--
http://download.windowsupdate.com/microsoftupdate/v6/wsusscan/wsusscn2.cab

Resolving download.windowsupdate.com (download.windowsupdate.com)...
217.32.28.8, 217.32.28.42

Connecting to download.windowsupdate.com
(download.windowsupdate.com)|217.32.28.8|:80... connected.

HTTP request sent, awaiting response...

  HTTP/1.1 200 OK

  Content-Type: application/octet-stream

  Last-Modified: Wed, 23 Nov 2011 01:07:07 GMT

  Accept-Ranges: bytes

  ETag: "80af26387ca9cc1:0"

  Server: Microsoft-IIS/7.5

  X-Powered-By: ASP.NET

  Content-Length: 29184228

  Expires: Mon, 05 Dec 2011 00:08:00 GMT

  Pragma: no-cache

  Date: Mon, 05 Dec 2011 00:08:00 GMT

  Connection: keep-alive

  Cache-Control: max-age=0

Length: 29184228 (28M) [application/octet-stream]

Saving to: address@hidden'

100%[=======================================================================
=======>] 29,184,228  2.93M/s   in 9.4s

2011-12-05 00:08:09 (2.95 MB/s) - address@hidden' saved
[29184228/29184228]

 

Appreciate if you could log and rectify this?  Can you confirm which change
in which release introduced this regression?

 

Apart from that thanks for a very handy little tool.

 

Thanks and kind regards

Richard Rudling