Re: [Bug-wget] empty VERSION in 1.13.4

[Paul Wratt]

will this now produce the same output as v1.12 using "wget --version"
which shows the ./configure options

On Tue, Dec 13, 2011 at 9:26 AM, Giuseppe Scrivano <address@hidden> wrote:
> Elan Ruusamäe <address@hidden> writes:
>
>> hi
>>
>> i reported on irc, but apparently nobody listens there:
>>
>> Day changed to 09 Dec  2011
>> 22:07:16  glen> 1.13.4 tarball is buggy. builds from it lack version
>> id in user agent header
>> 22:07:36  glen> $ wget -q -O -  ifconfig.me/ua
>> 22:07:44  glen> this prints: Wget/ (linux-gnu)
>> 22:08:03  glen> seems the problem is that tarball does not contain
>> this file: sh: build-aux/bzr-version-gen: not found
>> 22:08:12  glen> so regenerating autoconf creates empty @VERSION@
>> 22:08:28  glen> $ grep version.string src/version.c
>> 22:08:28  glen> const char *version_string = "";
>>
>> in pld linux i workarounded:
>> http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/wget/wget.spec?r1=1.158&r2=1.159
>> <http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/wget/wget.spec?r1=1.158&r2=1.159>
>
> Thanks for the report, this one-line patch should fix the problem:
>
> Cheers,
> Giuseppe
>
>
>
> === modified file 'ChangeLog'
> --- ChangeLog   2011-12-11 14:18:11 +0000
> +++ ChangeLog   2011-12-12 20:24:25 +0000
> @@ -1,3 +1,8 @@
> +2011-12-12  Giuseppe Scrivano  <address@hidden>
> +
> +       * Makefile.am (EXTRA_DIST): Add build-aux/bzr-version-gen.
> +       Reported by: Elan Ruusamäe <address@hidden>.
> +
>  2011-12-11  Giuseppe Scrivano  <address@hidden>
>
>        * util/trunc.c (main): Call `close' on the fd and check for errors.
>
> === modified file 'Makefile.am'
> --- Makefile.am 2011-01-01 12:19:37 +0000
> +++ Makefile.am 2011-12-12 20:14:16 +0000
> @@ -46,7 +46,7 @@
>  EXTRA_DIST = ChangeLog.README MAILING-LIST \
>              msdos/ChangeLog msdos/config.h msdos/Makefile.DJ \
>              msdos/Makefile.WC ABOUT-NLS \
> -             build-aux/build_info.pl .version
> +             build-aux/build_info.pl build-aux/bzr-version-gen .version
>
>  CLEANFILES = *~ *.bak $(DISTNAME).tar.gz
>
>