bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] mingw openssl fix and mingw issues


From: Giuseppe Scrivano
Subject: Re: [Bug-wget] mingw openssl fix and mingw issues
Date: Sun, 25 Mar 2012 17:00:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)

Ray Satiro <address@hidden> writes:

> A few other issues need to be addressed for mingw compile.
> 1. it seems gnulib does not address large file aware fstat/stat for
> mingw. I overrode this for my own build using a patch similar to that
> posted by Ángel González in the bootstrap thread.

I haven't looked at it, but in case it is a gnulib bug and it has to be
fixed there, I am sure they will accept such a fix.


> 2. gnulib ioctl.c mingw section does not have HANDLE type defined. I
> think that might be a gnulib oversight so I'll write them

hm.. where do we use it?  I can see it only in mswindows.c.


> 3. connect.c has checks for autoconf HAVE_SYS_ includes sys/socket and 
> sys/select, but AC_CHECK_HEADERS doesn't check sys/socket and also even if it 
> checks for them it's not checking gnulib headers. as a result of that 
> connect.c does not use the gnulib socket and select calls when it should.
>
> How to handle 1 and 3 in harmony with gnulib I don't know. For 3 I just 
> removed the check so that I could compile.

These checks shouldn't be there, we can assume these files always
exist.  I am going to remove them.


Thanks for the patch, I have applied and pushed it.

Giuseppe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]