Re: [Bug-wget] patch to fix some types of warnings

[Giuseppe Scrivano]

Hello Tim,

Tim Ruehsen <address@hidden> writes:

> function declaration isn't a prototype [-Wstrict-prototypes]
> no previous prototype for 'convert_links_in_hashtable' [-Wmissing-prototypes]
> suggest braces around empty body in an 'else' statement [-Wempty-body]
>
> please apply it to the repository.

please provide a ChangeLog entry for these entries.  Look at other
entries in the ChangeLog file to see how it should be done.

>            else
> +            {
>              /* Error in expiration spec.  Assume default (cookie doesn't
>                 expire, but valid only for this session.)  */
> -            ;
> +            }
>          }
>        else if (TOKEN_IS (name, "max-age"))
>          {
> @@ -434,8 +435,9 @@
>            cookie->secure = 1;
>          }
>        else
> +        {
>          /* Ignore unrecognized attribute. */
> -        ;
> +        }

I would rather move these comments near the if and explain what happens
in the particular case.  An empty branch is quite ugly.


> +# ifndef HAVE_LIBUUID
>  /* Fills uuid_str with a UUID based on random numbers.
>     (See RFC 4122, UUID version 4.)
>  
> @@ -612,6 +613,7 @@
>      uuid_data[10], uuid_data[11], uuid_data[12], uuid_data[13], 
> uuid_data[14],
>      uuid_data[15]);
>  }
> +#endif

Please provide it as a separate patch.

Thanks for your work!

Giuseppe