Re: [Bug-wget] need some advice for 0 timeout code

[Tim Ruehsen]

Am Tuesday 15 May 2012 schrieb Hrvoje Niksic:
> Tim Ruehsen <address@hidden> writes:
> > Am Tuesday 15 May 2012 schrieb Hrvoje Niksic:
> >> Tim Ruehsen <address@hidden> writes:
> >> > There are three obvious ways to fix the issue once and for all:
> >> > a)
> >> > when given the timeout value 0, use INFINITY and special handle this
> >> > value in select_fd() to call select with timeout NULL.
> >> 
> >> Why call select() or select_fd() at all when timeout is 0?
> > 
> > Some parts in the source call select_fd() with timeout==0, supposed to
> > return immediately with -1, 0 or 1.
> 
> And that's fine.  What I meant is: there is no need to even bother to
> call select_fd() in the case when the intended timeout is supposed to be
> infinite.
> 
> > Changing select_fd() simply won't work.
> 
> Agreed - however, I'm not proposing to change select_fd(), but its
> callers.  Wget code base has changed considerably since I last worked on
> it, so I could easily be missing something.

I just put some time into gnutls.c. It looks like just avoiding select and do 
blocking i/o makes gnutls hanging. This might of course be a side effect of 
some other involved parts of wget. Just tuning gnutls.c did not work so far.
If the server side does not close the connection, wget seems to get stuck in 
reading. Guiseppe had some discussion on gnutls-devel last year 
(http://lists.gnu.org/archive/html/gnutls-devel/2011-05/msg00028.html)

But thanks for your input.
It leads me to make a list of HTTP, HTTPS/openssl and HTTPS/gnutls timeout 
function/handling/status. Maybe there is an easy fix (hopefully with just 
gnutls.c involved).

Tim