[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] alpha release ( (was: [PATCH] gnutls.c: fi

From: Ray Satiro
Subject: Re: [Bug-wget] alpha release ( (was: [PATCH] gnutls.c: fix infinite read timeout)
Date: Tue, 22 May 2012 19:12:42 -0700 (PDT)

> From: Steven M. Schweda <address@hidden>

>    This problem on VMS is still unsolved:
> ALP $ gdiff -du src/connect.c_orig src/connect.c
> --- src/connect.c_orig  2012-05-12 10:18:27 -0500
> +++ src/connect.c       2012-05-22 07:59:19 -0500
> @@ -36,8 +36,13 @@
> #include <unistd.h>
> #include <assert.h>
> -#include <sys/socket.h>
> -#include <sys/select.h>
> +# include <sys/socket.h>
> +#endif /* def HAVE_SYS_SOCKET_H */
> +
> +# include <sys/select.h>
> +#endif /* def HAVE_SYS_SELECT_H */
> #ifndef WINDOWS
> # ifdef __VMS
>    I don't have anything like <sys/select.h>, and adding a dummy
> replacement would be annoying, because I also don't have a "sys"
> directory.  What's the point of defining the macros HAVE_SYS_SELECT_H
> and HAVE_SYS_SOCKET_H in src/config.h, and then not using them where
> appropriate?  (When asked for <sys/xxx.h>, the DEC/Compaq/HP compiler
> will look for <xxx.h> in its usual places, so "#include 
> <sys/socket.h>"
> actually works (using <socket.h>), but this will fail if I create a new
> "sys" directory for <sys/select.h>.  There may be some complex 
> and ugly
> work-around for this, bit it's simpler and cleaner to use the existing
> macros.  Which is why they exist, isn't it?)

Do you have in your wget gnulib dir lib\sys\ those includes? I was under the 
impression those were used.
This goes back to 

If you're going to use those then AC_CHECK_HEADERS or something needs to check 
for the gnulib includes. I think there was some problem with that. I can't find 
it in the thread but if I remember right rather than add to the check Giuseppe 
removed the HAVEs because they are always required.. aren't they?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]