Re: [Bug-wget] [PATCH] fix build warnings with newer zlib

[Mike Frysinger]

On Thursday 24 May 2012 16:09:31 Giuseppe Scrivano wrote:
> Mike Frysinger writes:
> > The gz* API from zlib takes a "gzFile", not a "gzFile*".  Older
> > versions of zlib didn't trigger a warning due to how the funcs
> > were written, but newer ones do.  So tweak the type (which in
> > reality shouldn't change anything since it's a typedefed pointer)
> > to work with old/new versions.
> 
> Then we should check, trough the configure script, that the zlib version
> used supports this new type.  I don't think there are problems to force
> the zlib version >= the last one supporting the new type, I am not
> particularly worried about not supporting old versions of the libraries.

that doesn't make sense here.  the zlib API has always defined gzFile, and has 
operated on that.  it has never utilized gzFile*.  the fact that it didn't 
warn in the past was due to the zlib API not containing code that'd implicitly 
check it, and the reason it doesn't fail at runtime is that gzFile internally 
is basically a pointer.  so a pointer to a struct is the same size as a 
pointer to a pointer, thus the ABI/generated code is unchanged.
-mike

signature.asc
Description: This is a digitally signed message part.