[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] fix build warnings due to DEBUG_MALLOC

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] [PATCH] fix build warnings due to DEBUG_MALLOC
Date: Tue, 28 Aug 2012 21:52:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

Mike Frysinger <address@hidden> writes:

> On Monday 21 May 2012 19:05:59 Mike Frysinger wrote:
>> The current cleanup_html_url code warns because it's marked static
>> but no one calls it.  Reading the code base, we see it only gets
>> called when DEBUG_MALLOC is defined, so change the static markings
>> to check that ifdef.

thanks for the patch, but I think these functions should not be defined
as static.  It would be fine to guard static functions used in the same
compilation unit but I prefer to define functions used from different
files in any case.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]