Re: [Bug-wget] [PATCH] Invalid Content-Length header in WARC files, on some platforms

[Giuseppe Scrivano]

Ángel González <address@hidden> writes:

> On 26/11/12 00:04, Giuseppe Scrivano wrote:
>> that is a good idea, we can add something like:
>>
>> #define MAX_INT_TO_STRING_LEN(x) (sizeof(x) * 24082 / 10000) + 2
>>
>> where `x' in our case will be off_t.
>>
>> I am not sure if such a function already exists somewhere.
>>
>> Does it improve readability?
> Well, that just brings the question «Where does 24082 come from?» but if
> that used for eg.
> #define STRSIZE_WGINT MAX_INT_TO_STRING_LEN(wgint)
>
> Then using STRSIZE_WGINT would be more readable :)

I think a simple comment can be enough ;)  I have pushed the change.

Cheers,
Giuseppe