[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Host header for CONNECT method
From: |
Ángel González |
Subject: |
Re: [Bug-wget] Host header for CONNECT method |
Date: |
Wed, 30 Jan 2013 15:28:24 +0100 |
User-agent: |
Thunderbird |
On 30/01/13 12:47, Pavel Mateja wrote:
> Hi,
> I tried new wget from debian squeeze with apache proxy and I ended with error
> message:
> AH00569: client sent HTTP/1.1 request without hostname (see RFC2616 section
> 14.23): /
> Apache source clearly says:
> /*
> * Client sent us an HTTP/1.1 or later request without telling us the
> * hostname, either with a full URL or a Host: header. We therefore
> * need to (as per the 1.1 spec) send an error. As a special case,
> * HTTP/1.1 mentions twice (S9, S14.23) that a request MUST contain
> * a Host: header, and the server MUST respond with 400 if it doesn't.
> */
>
> Compare with wget source:
> /* Examples in rfc2817 use the Host header in CONNECT
> requests. I don't see how that gains anything, given
> that the contents of Host would be exactly the same as
> the contents of CONNECT. */
>
> The answer is: you will gain compliance to RFC and compatibility.
> Check attached patch please.
Looks good, although I would keep a comment refering to rfc2817 and
mentioning
Apache enforcing the host requisite even for connect method.