[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Syntax for RESTful scripting options

From: Darshit Shah
Subject: Re: [Bug-wget] Syntax for RESTful scripting options
Date: Fri, 15 Mar 2013 16:44:42 +0530

I have implemented a --method command along with --body-data and
--body-file commands for HTTP Scripting.

Have attached the patch alongwith this mail. However, this is not complete,
not to my satisfaction atleast.
There is redundant code that executes the old --post-data and --post-file

I think these commands should be set as an alias to --body-data and
--body-file. While that is easily done by editing the commands[] array in
main.c the issue is, how best to set opt.meth od to POST.
Putting a conditional in setoptval() would be a terrible idea since it
causes an extra condition evaluation everytime for just one particular case.

But I am unable to think of any other method to merge the two internally.
Please do suggest something.

On Mon, Mar 11, 2013 at 8:14 PM, Giuseppe Scriuvano <address@hidden>wrote:

> Darshit Shah <address@hidden> writes:
> >    Also, alongwith implementing --body-data and --body-file should I mark
> >    the --post-data and --post-file commands as deprecated? Or is there a
> >    different protocol to follow before marking a command as deprecated?
> I don't see any real value to mark them as deprecated.  Let's live with
> them for now.
> Cheers,
> Giuseppe

Thanking You,
Darshit Shah
Research Lead, Code Innovation
Kill Code Phobia.
B.E.(Hons.) Mechanical Engineering, '14. BITS-Pilani

Attachment: implementMethod
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]