[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Syntax for RESTful scripting options

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] Syntax for RESTful scripting options
Date: Sat, 16 Mar 2013 21:34:16 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)

Hi Darshit,

Darshit Shah <address@hidden> writes:

> I have implemented a --method command along with --body-data and --body-file 
> commands for HTTP Scripting.
> Have attached the patch alongwith this mail. However, this is not complete, 
> not to my satisfaction atleast.
> There is redundant code that executes the old --post-data and --post-file 
> commands.

great work!  Just some comments:

+    else if (opt.method)
+      {
+        char *q;
+        int s = strlen (opt.method);
+        for ( q = opt.method; s>=0; ++q, s-- )
+          *q = c_toupper (*q);
+        meth = opt.method;
+      }

this could be simplified as:

for (q = opt.method; *q; ++q)

then you don't need s at all.

The new flags should be documented, could you add also the documentation
for those?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]