Re: [Bug-wget] Syntax for RESTful scripting options

[Darshit Shah]

Thanks!
I'll incorporate that advice in my code.
Also, I have the documentation ready in a separate branch. Will merge and
submit a final patch.

However, I would really like to remove the redundant code I have created by
testing for body_data || body_file and post_data || post_file separately.

These two are the same functionality, why not merge it internally. Only
issue is, how to do it efficiently?

I am unable to understand who to set two flags through setoptval() for a
given command without putting an if condition in there.


On Sun, Mar 17, 2013 at 2:04 AM, Giuseppe Scrivano <address@hidden>wrote:

> Hi Darshit,
>
> Darshit Shah <address@hidden> writes:
>
> > I have implemented a --method command along with --body-data and
> --body-file commands for HTTP Scripting.
> >
> > Have attached the patch alongwith this mail. However, this is not
> complete, not to my satisfaction atleast.
> > There is redundant code that executes the old --post-data and
> --post-file commands.
>
> great work!  Just some comments:
>
>
> +    else if (opt.method)
> +      {
> +        char *q;
> +        int s = strlen (opt.method);
> +        for ( q = opt.method; s>=0; ++q, s-- )
> +          *q = c_toupper (*q);
> +        meth = opt.method;
> +      }
>
> this could be simplified as:
>
> for (q = opt.method; *q; ++q)
>
> then you don't need s at all.
>
> The new flags should be documented, could you add also the documentation
> for those?
>
> Cheers,
> Giuseppe
>



-- 
Thanking You,
Darshit Shah
Research Lead, Code Innovation
Kill Code Phobia.
B.E.(Hons.) Mechanical Engineering, '14. BITS-Pilani