[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Remaining reference to opt.post_data (WARC in src/http.c)

From: Darshit Shah
Subject: Re: [Bug-wget] Remaining reference to opt.post_data (WARC in src/http.c)
Date: Wed, 24 Apr 2013 10:27:04 +0530

Thanks Gijs!
Guess I missed that line there.

Also, this does mean that we need better tests especially for Warc file

On Wed, Apr 24, 2013 at 2:25 AM, Giuseppe Scrivano <address@hidden>wrote:

> Gijs van Tulder <address@hidden> writes:
> > Hi,
> >
> > For the new --body-data option most of the code that used to reference
> > opt.post_data has been changed to use opt.body_data. I found one
> > remaining reference, hidden in one of the WARC-writing sections of
> > src/http.c. Wget would crash if you combine --body-data with
> > --warc-file.
> >
> > It's a simple fix. See the attached patch.
> thanks, I have just pushed it.
> --
> Giuseppe

Thanking You,
Darshit Shah
Research Lead, Code Innovation
Kill Code Phobia.
B.E.(Hons.) Mechanical Engineering, '14. BITS-Pilani

reply via email to

[Prev in Thread] Current Thread [Next in Thread]