Re: [Bug-wget] Segmentation fault with current development version of wget

[Giuseppe Scrivano]

Gijs van Tulder <address@hidden> writes:

> Hi Darshit,
>
> Darshit Shah wrote:
>> Unless we explicitly check for opt.method = POST, this will cause a lot
>> of issues. Since the macro is being called on every redirect, even
>> HEAD/PUT/OPTIONS headers will get suspended to give way to GET. That is
>> not the behaviour we want.
>
> Ah, I see it's more complicated. If I understand RFC 2616 correctly
> (section 10.3), suspending a PUT request in response to a redirect is
> incorrect. But so is changing a POST request to a GET in response to
> anything but a 303. But that's expected (and the current behaviour of
> Wget):

Thanks you both for the feedback.  Indeed, my first patch doesn't
consider this case.

RFC 2606 doesn't seem very clear about it, and I can't find anywhere
that PUT/OPTIONS/ANYTHING should be handled differently than POST wrt
redirections.  I don't see why suspending a PUT request would be
incorrect.  Darshit, do you have any pointer?

-- 
Giuseppe