[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] imperfect messages in alpha release

From: Darshit Shah
Subject: Re: [Bug-wget] imperfect messages in alpha release
Date: Sun, 2 Jun 2013 20:06:51 +0530

On Sun, Jun 2, 2013 at 3:39 PM, Benno Schulenberg <address@hidden>wrote:

> Hi,
> The 1.14.128 alpha release that was announced to the translators
> contains a few messages that have some defects.
> One is that the string:
> "Cookie coming from %s attempted to set domain to %s"
> was changed to:
> "Cookie coming from %s attempted to set domain to "
> This is not good, as some languages may require the domain
> name _not to be at the end.  In general messages should be
> complete sentences, with all subjects and objects included.
> Attached patch fixes this.

I was the one that submitted the commit that caused this. The reason was an
issue in the gnulib implementation of quotearg_style() which caused
incorrect output.

This was reported on this mailing list and patched by Ángel González.
You can read more about it here:

Your patch causes the issue to resurface. I believe, giving the correct
output in English is more important than giving incorrect output that works
correctly for translations.

You can notice the patch if you run the Test-cookies.px test and read the
output of the 5th test in it. The output incorrectly states:

> Cookie coming from localhost attempted to set domain to localhost.

I guess we must work with upstream to resolve this issue with the
quoteargs_style() function.

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]