Re: [Bug-wget] Segmentation fault with current development version of wget

[Darshit Shah]

On Mon, Jun 17, 2013 at 2:05 AM, Giuseppe Scrivano <address@hidden>wrote:

> Thanks, the code seems correct but since you are going to write a lot of
> code during your Summer of Code project, I will be very pedantic.  This
> time I have just amended the changes before push your patch.
>
>
> Darshit Shah <address@hidden> writes:
>
> >  Please be aware that Wget needs to know the size of the POST data in
> > -advance.  Therefore the argument to @code{--post-file} must be a regular
>
> we put two empty spaces after a sentence.  I have fixed this change in
> other places too.
>
>
> > +          switch (statcode)
> > +          {
>
> I have indented the '{' correctly.  Two empty spaces.  Same for the
> closing curly bracket.
>
>
> > +  if ((!(*dt & RETROKF) && !opt.content_on_error) || head_only ||
> (opt.method && strcasecmp (opt.method, "GET") != 0))
>
> long line, I have splitted it.
>

Thanks! And sorry for the goof ups in the formatting. I'm getting rusty.
Although, I must admit I wasn't aware of the convention to use two spaces
after each sentence and thought it was a mistake by someone.


-- 
Thanking You,
Darshit Shah