[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] cmd_string_uppercase

From: Ángel González
Subject: [Bug-wget] cmd_string_uppercase
Date: Sat, 22 Jun 2013 00:06:31 +0200
User-agent: Thunderbird

I noticed a gcc warning on cmd_string_uppercase() and ended up almost rewriting it, since I disliked the extra copy by cmd_string.

Also note that the if (!ret || q == NULL) was useless, since cmd_string always returns true, and q would never be NULL (it would have crashed inside xstrdup, see gnulib/lib/xmalloc.c).


Attachment: cmd_string_uppercase.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]