Re: [Bug-wget] cmd_string_uppercase

[Darshit Shah]

Looks good, though what compiler compiler flags do you have on? Since I
noticed no such warning.

On Sat, Jun 22, 2013 at 3:36 AM, Ángel González <address@hidden> wrote:

> I noticed a gcc warning on cmd_string_uppercase() and ended up almost
> rewriting it, since I disliked the extra copy by cmd_string.
>
> Also note that the if (!ret || q == NULL) was useless, since cmd_string
> always returns true, and q would never be NULL (it would have crashed
> inside xstrdup, see gnulib/lib/xmalloc.c).
>
> Regards
>
>


-- 
Thanking You,
Darshit Shah