bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] GSoC 2013 project on rewriting Test Suite in Python.


From: Tim Rühsen
Subject: Re: [Bug-wget] GSoC 2013 project on rewriting Test Suite in Python.
Date: Sat, 29 Jun 2013 21:59:24 +0200
User-agent: KMail/1.13.7 (Linux/3.9-1-amd64; KDE/4.8.4; x86_64; ; )

> Though if XML is not easy to read/write, is there an alternative you would
> prefer? I am still open to modifying that.

I am the wrong guy to answer that ;-). I already stated my preferation of C 
code. But that won't help you, since you are fixed to Python.

Here are some spontaneous ideas (braindump).

An option would be to support XML (e.g. Test-xyz.xml) and a simple key/value 
text file (e.g. Test-xyz.txt). Both, XML and TXT have their pros and cons. So I 
won't say, one is better than the other... but it gives contributors a choice.

Just a quick shot:
# Server settings
server.file.name="file.html"
server.file.body="<html>dontcare</html>"
# server.response.code="200 dontcare"

# Wget options
wget_options="-d -c"

# Wget result code
wget_result=0

# client file existing before request
client.existfile.name=$server.file.name
client.existfile.body="<html>dontcare</ht"

# expected client file after request
client.file.name=$server.file.name
client.file.body=$server.file.body


You will just have two input file parsers, but the core of the test suite will 
stay the same as with XML only.


A few other ideas:
Maybe you can rename 'Special' to 'Server' or 'ServerRules' or something.
I find 'Special' is too generic and unintuitive.

You could simplify the server / special rules.
'Content Disposition' can be substituted by 'Header'.
When having a 'Code' element, you maybe won't need a 'Redirect' element 
('Code' and 'header' can substitute 'Redirect' !?)

Tim



reply via email to

[Prev in Thread] Current Thread [Next in Thread]