Re: [Bug-wget] Detected bugs by bugprobe

[Darshit Shah]

Hi Yan,

Thanks for the analysis.

The followings are some bugs found by our static analysis tool bugprobe in
> wget-1.14.
> In file recur.c
> At line 281, function url_parse may return NULL assigned to url_parsed.
> Function retrieve_url use url_parsed without null check.
>
>
> All program points that call function url_parse also exist this kind of
> bugs.
>
> I think this is already handled, since I tried making the code fail
through a few test cases, but couldn't. Even if url_parse returns a NULL
value, wget exits gracefully with a meaningful error message.

I think I remember seeing some code that handled this issue, but I'm not
sure exactly where. Probably, the issue isn't handled correctly, and there
may be an edge case. Will have to look into the code thoroughly to check it
out.

-- 
Thanking You,
Darshit Shah