bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [ PATCH ] LIST changes (ver. 3)


From: Andrea Urbani
Subject: Re: [Bug-wget] [ PATCH ] LIST changes (ver. 3)
Date: Fri, 18 Oct 2013 08:36:49 -0400

Hello Tim,

about previous_rd_size you can initialise it at 0 where it is declared.

About indentation and/or other points just let me know and I will "patch 
myself", if it is just about coding... :)

Bye
Andrea

----- Original Message -----
From: Tim Ruehsen
Sent: 10/18/13 10:44 AM
To: address@hidden
Subject: Re: [ PATCH ] LIST changes (ver. 3)

Hi Andrea, good work ! I could apply the new patch, the test suite runs 
smoothly. Some recursive tests on random ftp servers not in your list worked 
well. There is one little thing: ftp.c:1496:21: warning: 'previous_rd_size' may 
be used uninitialized in this function [-Wmaybe-uninitialized] else if ( 
previous_rd_size > rd_size ) Guiseppe might have some (indentation) remarks. I 
hope, your patch makes it into Wget beforethe next release. Tim


reply via email to

[Prev in Thread] Current Thread [Next in Thread]