[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH v4] Make wget capable of starting download from a
Re: [Bug-wget] [PATCH v4] Make wget capable of starting download from a specified position.
Thu, 06 Feb 2014 10:10:40 +0100
KMail/4.11.5 (Linux/3.12-1-amd64; KDE/4.11.5; x86_64; ; )
please don't forget to send your posts to the mailing list.
On Thursday 06 February 2014 10:27:37 Yousong Zhou wrote:
> On Wednesday, February 5, 2014, Tim Ruehsen <address@hidden> wrote:
> > First of all, thanks for your contribution.
> > I have some little remarks / questions:
> > - The documentation is not quite right: when using --start-pos and the
> > file
> > already exists, wget creates as expected a file.1.
> > But your docs say, --start-pos would overwrite an existing file !?
> > Could you make this point clear ?
> Yes, 'overwrite' is wrong.
> > - The combination with --continue works for me as expected. It would
> > simply
> > append the downloaded bytes to the existing file. Maybe you should
> > document
> > that as well. At least your sentence "... it would override the behavior
> > of --
> > continue" seems not to be correct.
> Sorry for the confusion. --continue will detect size of existing file,
> then continue as if an equivalent --start-pos was specified. By 'override'
> I mean the new option has higher precedence over --continue. Other than
> that, all existing behaviors of wget are supposed to remain unchanged.
> > - What about extending the option to something like
> > --range=STARTPOS[-ENDPOS]
> > ?
> You mean change the option name to 'range'? IIRC, that's how curl does it.
> I am okay with --start-pos. ;)
I just wanted to mention a possible 'ENDPOS'. In that case --start-pos isn't
appropriate any more and --range seems natural to me.
I just took a look at curl's man page. The curl people did it the right way.
Especially their hint about multipart responses is of value (i didn't know
that). Such cases would likely need special handling in Wget.
> > - If you want to brush up your patch, add a test-case for it for the new
> > Python based test suite. I guess, Darshit can give you a helping hand, if
> > you
> > request it.
> Will do once I get the time.
> > Tim
> Thank you for looking at this.
> > > --start-pos is zero-based.
> > >
> > > v2 -> v3
> > >
> > > Fix a typo and add description text for the new option into the
> > >
> > the suggestions.
> > > v1 -> v2
> > >
> > > It was kindly pointed out by Darshit Shah
> > that
> > > server support for resuming download is required, so adding this
> > >
> > > into doc/wget.texi.
> > >
> > > doc/ChangeLog | 4 ++++
> > > doc/wget.texi | 17 +++++++++++++++++
> > > src/ChangeLog | 9 +++++++++
> > > src/ftp.c | 2 ++
> > > src/http.c | 2 ++
> > > src/init.c | 1 +
> > > src/main.c | 3 +++
> > > src/options.h | 1 +
> > > 8 files changed, 39 insertions(+), 0 deletions(-)