[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] bug#16843: Error caused due to regression in git

From: Darshit Shah
Subject: Re: [Bug-wget] bug#16843: Error caused due to regression in git
Date: Mon, 24 Feb 2014 21:09:18 +0100

On Mon, Feb 24, 2014 at 9:05 PM, Eric Blake <address@hidden> wrote:

> On 02/24/2014 12:53 PM, Eric Blake wrote:
> > Yay - you confirmed that the solution that works for both versions of
> > git is to ensure that we provide exactly one argument to the foreach
> > command, where that argument gets passed through the shell with
> > identical results.  I'll patch maint.mk shortly.
> Actually, it turns out that the problem has already been fixed upstream:
> commit 7a0c729aacc3716a665ce3b0c8cb34843bdecc75
> Author: Jim Meyering <address@hidden>
> Date:   Wed Jan 1 20:25:44 2014 -0800
>     maint: fix public-submodule-commit to work with newer git
>     * top/maint.mk (public-submodule-commit): Remove excess quoting.
>     We were over-quoting the test arguments, and somewhere prior to
>     version, git stopped removing those excess quotes,
>     which made the test fail, since the unexpanded strings would
>     always differ; using GIT_TRACE=1 confirmed that the git merge-base
>     command wasn't even being run.
> So all that remains now is for the package you were complaining about to
> upgrade to a newer version of gnulib that plays nicely with git 1.9 and
> newer.
> Thanks Eric!

I'll notify them of the fact.

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]