[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [GSoC] Refactoring the Test Suite

From: Darshit Shah
Subject: Re: [Bug-wget] [GSoC] Refactoring the Test Suite
Date: Sun, 9 Mar 2014 02:22:59 +0100


Thanks for the refactoring. However, you've included makefile and
makefile.in which are autogenerated files and should not be commited.

Also, your patch has trailing whitespace errors. And I don't think you've
added an entry to ChangeLog either. Please look into these. I haven't seen
your patch yet. The Makefile errors mean I can't apply it without a lot of
extra work.

On Sat, Mar 8, 2014 at 5:38 PM, 陈子杭 (Zihang Chen) <address@hidden>wrote:

> Hi.
> Here's a patch refactoring CommonMethods, HTTPTest and project hierarchy.
> 19 tests passed, 1 xfailed as expected.
> Let me know if there's any problem.
> --
> Regards,
> Chen Zihang,
> Computer School of Wuhan University
> ---
> 此致
> 陈子杭
> 武汉大学计算机学院

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]