[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget
From: |
Jure Grabnar |
Subject: |
Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget |
Date: |
Fri, 28 Mar 2014 13:33:37 +0100 |
Hi,
Thank you Yousong. I've listened to your advice and changed type of
resource->type to
enum url_scheme. Now it looks much cleaner.
I also added check for whenever there's no resources available to download
a file.
Second patch remains unchanged.
Regards,
Jure Grabnar
On 27 March 2014 16:58, Jure Grabnar <address@hidden> wrote:
> I didn't have time since the last upload (I'm planning to change
> 'resource->type' type to enum url_scheme). I'll try to upload it
> today/tomorrow.
>
> Regards,
>
>
> Jure Grabnar
>
>
> On 27 March 2014 14:41, Darshit Shah <address@hidden> wrote:
>
>> Any updates on this set of patches?
>>
>> On Sat, Mar 22, 2014 at 12:05 PM, Yousong Zhou <address@hidden>
>> wrote:
>> > Hi, Jure.
>> >
>> > On 22 March 2014 18:02, Jure Grabnar <address@hidden> wrote:
>> >> Hi,
>> >>
>> >> thank you for your feedback, Darshit, Yousong!
>> >>
>> >> I reverted magic number back to its original state ('tmp2'), because it
>> >> should
>> >> be there (I overlooked that 'tmp' variable is changed in the very next
>> >> statement).
>> >>
>> >> Duplicated line is removed.
>> >>
>> >> I also changed resource->type to point at dynamic memory.
>> >
>> > + if (type)
>> > + {
>> > + resource->type = malloc (strlen (type));
>> > + sprintf(resource->type, type);
>> > + }
>> >
>> > xstrdup() is better because that is how existing code does it. And
>> > you may want to know that using a variable as the format string is not
>> > a good practice for secure code.
>> >
>> > yousong
>> >
>> >>
>> >> They say third's time's the charm. :) I hope it's ok now.
>> >>
>> >> Regards,
>> >>
>> >>
>> >> Jure Grabnar
>> >>
>> >>
>>
>>
>>
>> --
>> Thanking You,
>> Darshit Shah
>>
>
>
0001-Fix-metalink-issues-when-type-is-not-present.patch
Description: Text Data
0002-Fix-some-compiler-warnings.patch
Description: Text Data
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, (continued)
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/17
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/19
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/20
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/20
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/21
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/21
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/22
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/22
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/27
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/27
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget,
Jure Grabnar <=
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/28
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/30
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/31
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/31