[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Bug-Wget] It's spring cleaning time!

From: Darshit Shah
Subject: Re: [Bug-wget] [Bug-Wget] It's spring cleaning time!
Date: Mon, 31 Mar 2014 02:42:49 +0200

On Sun, Mar 30, 2014 at 9:35 PM, Tim Rühsen <address@hidden> wrote:
> Am Sonntag, 30. März 2014, 16:00:07 schrieb Darshit Shah:
>> Hello,
>> I've been wanting to clean up the code for Wget for some time now.
>> Today, I wrote a small script that compiles Wget with a bunch of
>> warning flags and uploads each warning to GitHub as an issue.
>> These issues have been created against the fork of Wget that I
>> maintain on https://github.com/darnir/wget
>> As of now, I compiled Wget using Clang and CFLAGS="-Wextra -Wall
>> -pedantic -std=gnu89"
>> These flags end up spewing around 60 warnings, all of them semantic
>> issues. The issues have been labeled based on the flag that caused
>> them and the type of issue it is according to clang.
>> I wanted to run clang with -Weverything, but that throws nearly 800+
>> warnings. Hence, I figured, let's clean this up first and we can then
>> begin looking at the other warnings. Some of them are probably false
>> positives, but tohers seem to have some more subtle problems with
>> platform independence.
> I like the idea (always liked it) to fix all these warnings - I guess some of
> my patches were lost...
Aah! I've been working on some cleaning too. Sadly, I ran a `git reset
--hard origin/master` too quickly. Before I could even commit the
changes. Now, those are lost. I'll work on them again.

> However you define "false positive", they simply pollute the screen and when
> searching for real issues, you have to read through again and again. In this
> meaning, there is no false positive - except the compiler has a bug (the clang
> analyzer really finds some (cough) interesting things).
Yes. Clang is still under development and finds some crazy things.
I'll try and have the script work with GCC. I chose clang because its
my default compiler and also, I plan on hooking into libclang at some
point, so the script doesn't have to parse things.

> I once made a patch that fixed those 'const' warnings when compiling with -
> DDEBUG (triggers selftest code). But I think it was not applied :-(
If you have the patch, please do send it again!

> However, good idea, and I try to find some time !
Thanks.. I'll try and fix a few things in the meanwhile.
> Tim

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]