Re: [Bug-wget] --progress should not be overridden by --quiet

[Darshit Shah]

On Thu, Apr 17, 2014 at 2:49 PM, Gisle Vanem <address@hidden> wrote:
> "Darshit Shah" <address@hidden> wrote:
>
>> progress bar to me. It does not change the existing output so we have
>> full backward compatibility with existing scripts, but allows the user
>> to explicitly display the progress bar if required.
>
>
> I don't see your patch is considering the Windows console-title
> progress indicator. In e.g. retr.c:
>
You're right. I completely forgot about the Windows console title. I
have only considered the progress bar output right now. I'll look into
mswindows.c and fix that in a while.

Thanks a lot for pointing this out. :)

> #ifdef WINDOWS
>      if (toread > 0 && !opt.quiet)
>        ws_percenttitle (100.0 *
>                         (startpos + sum_read) / (startpos + toread));
> #endif
>
> Maybe this should test for this new option too? Something like:
>      if (toread > 0 && !opt.quiet || opt.show_progress)
>     ...
>
> But mswindows.c always needs a 'curr_url' to show percentage.
> I don't think 'ws_changetitle()' will be called as needed for this to
> happen. The best IMHO would be to drop 'ws_changetitle()' and always have
> the current-URL as a parameter to 'ws_percenttitle()'.
>

I honestly haven't looked at the Windows specific part of the codebase
at all, so I don't know how mswindows.c works. I'll however give it a
look when I can.

> --gv
>



-- 
Thanking You,
Darshit Shah