bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Bug-Wget][Patch] Implement --show-progress


From: Darshit Shah
Subject: Re: [Bug-wget] [Bug-Wget][Patch] Implement --show-progress
Date: Tue, 29 Apr 2014 14:40:41 +0200

Hi,

On Tue, Apr 29, 2014 at 2:31 PM, Giuseppe Scrivano <address@hidden> wrote:
> Darshit Shah <address@hidden> writes:
>
>> Recently we received a feature request fromt he good guys at RedHat.
>> I've personally wanted this feature implemented in master for a while
>> now and was maintaining a hacked up version of the patch to do so
>> myself. After some cleaning up, I submitted a patch some time ago.
>>
>> Here, is v2 of that patch. Since I'm using a different thread for
>> this, I'll just explain all the changes here.
>>
>> The first patch is essentially Giuseppe's patch on parallel-wget
>> merged into master. It splits the progress implementation into
>> separate functions for update and draw which I think is a very good
>> idea.
>>
>> The second patch is mostly my own work. It does two important things,
>> which probably should be different patches, but they are so
>> intertwined, that I decided to turn it into a single patch.
>>
>> First of all, we implement the new --show-progress switch which can be
>> used to force Wget into displaying the progress bar in any verbosity
>> mode. Since the default output hasn't been changed in any verbosity
>> mode, no one can complain I broke their scripts.
>> Secondly, I edit the \default\ progress-bar implementation in Wget. It
>> now displays the local filename of the file being downloaded in the
>> progress bar itself. This is a very useful thing to have in
>> conjunction with the --show-progress switch. Now, when I force Wget to
>> display the progress bar in --quiet mode, I can still see the name of
>> the file that will be created.
>>
>> Since Wget displays the dot bar by default when output has been
>> redirected to a file, this should not break any scripts once again.
>>
>> One small section of the code in the second patch, the one that
>> implements the filename ticker in the progress bar, was copied for
>> Giuseppe's patch on parallel-wget.
>> @Giuseppe: Attribute yourself on that the way you see fit.
>
> seeing the code used is more than enough, thanks to have backported it
> :-).
> I personally have no complains about it, so if nobody will say anything
> I will merge it later, good job!
>
Great! I'd really like to see this progress implementation go out. I
really like the way it's been done. And it paves the way for
parallel-wget since that must use a progress bar like this instead of
what we already have.

> I've tried a quick merge into parallel-wget but it failed.  Have you
> already ported it there?  If not, don't worry about that, I will fix
> these conflicts.

No, I haven't tried porting this code into parallel-wget yet. We'd
have to edit all the calls to fd_read_body() which I'm assuming have
shifted by a large amount so we'll have to manually merge it. This set
of patches is for master only.
>
> Regards,
> Giuseppe



-- 
Thanking You,
Darshit Shah



reply via email to

[Prev in Thread] Current Thread [Next in Thread]