Re: [Bug-wget] [Bug-Wget] It's spring cleaning time!

[Darshit Shah]

On Sun, May 11, 2014 at 8:21 PM, Tim Rühsen <address@hidden> wrote:

> Am Sonntag, 11. Mai 2014, 15:56:15 schrieb Giuseppe Scrivano:
> > Darshit Shah <address@hidden> writes:
> > > Subject: [PATCH] Fix LOTS of compiler warnings
> >
> > great work!  Just some minor comments:
> > >     * http.c: Fix small memory leak
> > >
> > > diff --git a/src/css-url.c b/src/css-url.c
> > > index f97690d..51e43b4 100644
> > > --- a/src/css-url.c
> > > +++ b/src/css-url.c
> > > @@ -64,8 +64,8 @@ typedef struct yy_buffer_state *YY_BUFFER_STATE;
> > >
> > >  extern YY_BUFFER_STATE yy_scan_bytes (const char *bytes,int len  );
> > >  extern int yylex (void);
> > >
> > > -#if 1
> > > -const char *token_names[] = {
> > > +#if 0
> > > +static const char *token_names[] = {
> > >
> > >    "CSSEOF",
> > >    "S",
> > >    "CDO",
> >
> > if this is not needed, what about just dropping it?  I would prefer we
> > keep code that is used somewhere.
>
> Then let's drop it.
> Due to version control, the code is not really lost... (if someone minds to
> use it again).
>
> >
> > > -#define NTLMFLAG_NEGOTIATE_DOMAIN_SUPPLIED       (1<<12)
> > > -#define NTLMFLAG_NEGOTIATE_WORKSTATION_SUPPLIED  (1<<13)
> > > -#define NTLMFLAG_NEGOTIATE_LOCAL_CALL            (1<<14)
> > > -#define NTLMFLAG_NEGOTIATE_ALWAYS_SIGN           (1<<15)
> > > -#define NTLMFLAG_TARGET_TYPE_DOMAIN              (1<<16)
> > > -#define NTLMFLAG_TARGET_TYPE_SERVER              (1<<17)
> > > -#define NTLMFLAG_TARGET_TYPE_SHARE               (1<<18)
> > > -#define NTLMFLAG_NEGOTIATE_NTLM2_KEY             (1<<19)
> > > -#define NTLMFLAG_REQUEST_INIT_RESPONSE           (1<<20)
> > > -#define NTLMFLAG_REQUEST_ACCEPT_RESPONSE         (1<<21)
> > > -#define NTLMFLAG_REQUEST_NONNT_SESSION_KEY       (1<<22)
> > > -#define NTLMFLAG_NEGOTIATE_TARGET_INFO           (1<<23)
> > > +/* #define NTLMFLAG_NEGOTIATE_DOMAIN_SUPPLIED       (1<<12) */
> > > +/* #define NTLMFLAG_NEGOTIATE_WORKSTATION_SUPPLIED  (1<<13) */
> > > +/* #define NTLMFLAG_NEGOTIATE_LOCAL_CALL            (1<<14) */
> > > +/* #define NTLMFLAG_NEGOTIATE_ALWAYS_SIGN           (1<<15) */
> > > +/* #define NTLMFLAG_TARGET_TYPE_DOMAIN              (1<<16) */
> > > +/* #define NTLMFLAG_TARGET_TYPE_SERVER              (1<<17) */
> > > +/* #define NTLMFLAG_TARGET_TYPE_SHARE               (1<<18) */
> > > +/* #define NTLMFLAG_NEGOTIATE_NTLM2_KEY             (1<<19) */
> > > +/* #define NTLMFLAG_REQUEST_INIT_RESPONSE           (1<<20) */
> > > +/* #define NTLMFLAG_REQUEST_ACCEPT_RESPONSE         (1<<21) */
> > > +/* #define NTLMFLAG_REQUEST_NONNT_SESSION_KEY       (1<<22) */
> > > +/* #define NTLMFLAG_NEGOTIATE_TARGET_INFO           (1<<23) */
> >
> > same here, what about just dropping them?
>
> Yes, same here.
>
> Darshit, I guess it would be easiest if you change the patch !?
>
> Tim
>
>
Not too hard.

Here it is.

-- 
Thanking You,
Darshit Shah

0001-Fix-compiler-warnings.patch
Description: Text Data