Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

[Darshit Shah]

On Sun, Jun 1, 2014 at 2:35 AM, Ángel González <address@hidden> wrote:
> On 31/05/14 21:30, Darshit Shah wrote:
>>
>> +     * [35]libpsl is (optionally) required for checking cookie domains.
>> +
>
> It's weird to have something "optionally required". I would remove
> "(optionally)"
> and add it at the list on the top of "not absolutely required" dependencies.
>
Yes. That file could do with a small overhaul.
>
> That file needs a bit more love, though. I would leave the bullets as:
> * <package> <what provides>
>
> removing the "is needed"/"is required" texts. And adding "(optional)" at the
> end
> where appropiate.
>
I'll try and rework that file. But The kind of changes you suggest
would better be made in a different patch to separate them from the
libpsl changes.

> That file comes from http://wget.addictivecode.org/CompilingRepoSources so I
> propose we work on it there, and later merge it to the repo.
>
Maybe that should be changed as well. Let me look into the whole thing
with a fresh mind.



-- 
Thanking You,
Darshit Shah