Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

[Tim Rühsen]

Am Mittwoch, 11. Juni 2014, 18:57:13 schrieb Darshit Shah:
> On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen <address@hidden> wrote:
> > Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
> >> I'm facing an issue with the patch I submitted for libpsl and would be
> >> glad if someone could help me.
> >> 
> >> The configure.ac file does not work as expected. When libpsl is not
> >> installed on a system, the LDFLAGS does not contain -lpsl flag, but
> >> the configure summary shows LIBPSL: Yes.
> >> 
> >> There is some discrepency in the output that I'd like to fix. The
> >> build completes successfully because the HAVE_LIBPSL variable isn't
> >> set, and Wget compiles without libpsl support. This should however
> >> happen only when --without-libpsl was explicitly specified as a
> >> configure option.
> > 
> > This should do it:
> > 
> > AC_ARG_WITH(libpsl,
> > 
> >     AS_HELP_STRING([--without-libpsl], [disable support for libpsl cookie
> >     checking.]), [
> >     
> >       with_libpsl=no
> >     
> >     ], [
> >     
> >       AC_CHECK_LIB(psl, psl_builtin,
> >       
> >                    [with_libpsl=yes; AC_DEFINE([WITH_LIBPSL], [1], [PSL
> >                    support enabled]) LIBS="${LIBS} -lpsl"],
> >                    [with_libpsl=no; AC_MSG_WARN(*** libpsl was not found.
> >                    Fallback to Wget builtin cookie checking.)])>     
> >     ])
> > 
> > But I can't compile the gnulib when having WITH_LIBPSL=1.
> > ./configure sets FTELLO_BROKEN_AFTER_SWITCHING_FROM_READ_TO_WRITE to 1
> > which causes undefined fp_ which causes headaches with some SOLARIS code
> > :-(
> 
> Hi Tim,
> 
> Thanks for the patch. But it didn't help solve the problem. When
> libpsl isn't installed, by default ./configure succeeds but make fails
> because it somehoe detects libpsl even through it isn't installed on
> the system.

I tested it and it works ok.
Perhaps you made a mistake somewhere !?

I attached my current configure.ac - please give it a try. Don't forget 
'autoreconf' after changing configure.ac. After that I do
./configure
make clean
make

If libpsl is still detected, make sure you really uninstalled libpsl.
Also 'grep -i PSL src/config.h config.log', HAVE_LIBPSL should be unset in 
src/config.h.

Further steps include looking into config.log (search for psl) to see what is 
going on.

Shouldn't be too hard to find.

Tim

configure.ac
Description: Text document