Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

[Darshit Shah]

Yes, the configure statements given by Tim work. I found out that the issue on 
machine was caching of configure values. Deleting the configure cache fixed the 
issue. 

I also agree with Giuseppe's point about not using the autoconf variables. 
Let's fix the rest of them too. 
Tim's patch however seems to add -lpsl twice for me. Removing the line that 
explicitly adds it to LIBS does the trick for me. 

P.S. Currently on mobile. Sorry for any formatting errors. 

—
Thanking you, 
Darshit Shah 
Sent from mobile. Please excuse any errors.

On Thu, Jun 12, 2014 at 4:54 PM, Giuseppe Scrivano <address@hidden>
wrote:

> Darshit Shah <address@hidden> writes:
>> On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen <address@hidden> wrote:
>>> Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
>>>> I'm facing an issue with the patch I submitted for libpsl and would be
>>>> glad if someone could help me.
>>>>
>>>> The configure.ac file does not work as expected. When libpsl is not
>>>> installed on a system, the LDFLAGS does not contain -lpsl flag, but
>>>> the configure summary shows LIBPSL: Yes.
>>>>
>>>> There is some discrepency in the output that I'd like to fix. The
>>>> build completes successfully because the HAVE_LIBPSL variable isn't
>>>> set, and Wget compiles without libpsl support. This should however
>>>> happen only when --without-libpsl was explicitly specified as a
>>>> configure option.
>>>
>>> This should do it:
>>>
>>> AC_ARG_WITH(libpsl,
>>>     AS_HELP_STRING([--without-libpsl], [disable support for libpsl cookie 
>>> checking.]),
>>>     [
>>>       with_libpsl=no
>>>     ], [
>>>       AC_CHECK_LIB(psl, psl_builtin,
>>>                    [with_libpsl=yes; AC_DEFINE([WITH_LIBPSL], [1], [PSL 
>>> support enabled]) LIBS="${LIBS} -lpsl"],
>>>                    [with_libpsl=no; AC_MSG_WARN(*** libpsl was not found. 
>>> Fallback to Wget builtin cookie checking.)])
>>>     ])
>>>
> I've not tested it but I think this version should fix the problem we
> had before.  Just one observation, can we use a different name instead
> of "with_libpsl"?  AFAICS, it is used only to display a message at the
> end of the configure script, so I would prefer we don't mess with
> variables set already by autoconf.
> We will then need to set it to no before the AC_CHECK_LIB is used.
> Thanks,
> Giuseppe