[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH 02/14] Do not use exit() with a magic number
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] [PATCH 02/14] Do not use exit() with a magic number |
Date: |
Thu, 12 Jun 2014 18:49:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
"Gisle Vanem" <address@hidden> writes:
> <address@hidden> wrote:
>
> ...
>
>> diff --git a/src/mswindows.c b/src/mswindows.c
>> index 179773e..c0d9be6 100644
>> --- a/src/mswindows.c
>> +++ b/src/mswindows.c
>> @@ -308,7 +308,7 @@ cleanup:
>>
>> /* We're the parent. If all is well, terminate. */
>> if (rv)
>> - exit (0);
>> + exit (WGET_EXIT_SUCCESS);
>
> This breaks compilation of mswindows.c as I wrote to Guiseppe
> privately; add "exits.h" at top.
thanks, I've fixed locally the source file, as you reported.
Regards,
Giuseppe
- [Bug-wget] [PATCH 00/14] fix "make syntax-check", gscrivano, 2014/06/11
- [Bug-wget] [PATCH 01/14] main: make program_name not static, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 02/14] Do not use exit() with a magic number, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 03/14] Do not include strings.h, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 06/14] Remove trailing whitespaces, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 04/14] Drop usage of strncpy, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 08/14] Remove trailing empty lines, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 09/14] Replace @VAR@ in Makefile.am files with $VAR, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 05/14] Update fdl.texi from gnulib, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 07/14] Ensure main calls bindtextdomain, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 10/14] Do not depend on always defined macros, gscrivano, 2014/06/11
- [Bug-wget] [PATCH 11/14] po/POTFILES.in: add missing file, gscrivano, 2014/06/11