bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] Dangling info->lfilename


From: Gisle Vanem
Subject: [Bug-wget] Dangling info->lfilename
Date: Tue, 17 Jun 2014 11:10:11 +0200

Hello Giuseppe.

You patch to mswindows.c at
 
http://git.savannah.gnu.org/cgit/wget.git/commit/src/mswindows.c?id=8e6de1fb5ff0ca0c749da7db634a1b1e3a1215a2

@@ -123,7 +123,7 @@ struct fake_fork_info
{
HANDLE event;
bool logfile_changed;
- char lfilename[MAX_PATH + 1];
+ char *lfilename;
};

Causes a dangling pointer after use. I.e.
 info->lfilename = strdup (opt.lfilename);

seems never to be freed. We should call free() *before*
'info' gets unmapped or revert that change.

--gv




reply via email to

[Prev in Thread] Current Thread [Next in Thread]