[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] [PATCH] Fix for checking iconv_open return code

From: Tomas Hozza
Subject: [Bug-wget] [PATCH] Fix for checking iconv_open return code
Date: Mon, 7 Jul 2014 16:31:59 -0400 (EDT)


Recently I discovered a mistake in wget's source, while browsing is.
in iri.c function locale_to_utf8() wrongly checked the return code
of the iconv_open() call [1]. There was "!=" instead of "==".

The patch is attached.

Anyway while trying to reproduce the issue, I realized that the function
is not used in wget at all. It was introduced in 2008 as part of initial
IDN support, but then replaced by remote_to_utf8(). So possibly it can
be completely removed, or the IDN code is not using it by mistake. I didn't
investigate the issue further.


Tomas Hozza
Software Engineer - EMEA ENG Developer Experience

Red Hat Inc.                               http://cz.redhat.com

Attachment: 0001-Fix-checking-of-iconv_open-return-code.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]