Re: [Bug-wget] [PATCH] Allow to redefine ciphers list for OpenSSL

[Giuseppe Scrivano]

Tomas Hozza <address@hidden> writes:

> I agree. The patch didn't take any configuration possibility from the user.
> The users would be able to configure whatever in the same way they were 
> before.
>
> Please really see some of those patches I sent. The discussion was little
> bit confusing at some points ~ like the intentions were interpreted 
> differently.

some minor comments:

> From c92ebeb4892fd355489641ab544af502dcad0ae5 Mon Sep 17 00:00:00 2001
> From: Tomas Hozza <address@hidden>
> Date: Thu, 10 Jul 2014 14:14:19 +0200
> Subject: [PATCH] Add configure option --with-ciphers-list v3

s| v3||

this should go into [PATCH] if you use --annotate with git send-email.

> 
> Allow the users to redefine the ciphers list used
> when compiled with OpenSSL. This is usable for
> distributions, that distribute wget as binary package
> and want to use own system-wide ciphers list.


> version 2:
> Print the ciphers list with --version, if it was
> redefined using configure script option.
> 
> version 3:
> Option renamed to --with-ciphers-list.
> Added support to redefine hardcoded ciphers list
> also for GnuTLS.

same here, these two should go after --, if you use git send-email.

I was really going to amend these two changes by myself before pushing,
but I've noticed a test fails here for me after your patch:

Unknown: Test-proxied-https-auth.px


Does it happen for you as well?

Thanks,
Giuseppe