[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] PATCH] main.c: update the --method description
From: |
Darshit Shah |
Subject: |
Re: [Bug-wget] PATCH] main.c: update the --method description |
Date: |
Wed, 23 Jul 2014 18:28:01 +0530 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jul 23, 2014 at 02:13:07PM +0200, Daniel Stenberg wrote:
> Hi,
>
> The 'method' in a HTTP request is not part of a header, it is the
> request-line. See patch!
Good catch! It was a stupid typo. I'll add the ChangeLog and push it.
Method is indeed a request line not a header.
>
> --
>
> / daniel.haxx.se
> From 75e193b01899f2280d9843e7a079c0679af148e5 Mon Sep 17 00:00:00 2001
> From: Daniel Stenberg <address@hidden>
> Date: Wed, 23 Jul 2014 14:10:18 +0200
> Subject: [PATCH] main.c: update the --method description
>
> The first line of a HTTP request is not a header, it is the start-line,
> which for requests is called the request-line.
>
> See http://tools.ietf.org/html/rfc7230#section-3.1
> ---
> src/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/main.c b/src/main.c
> index 70930dd..1ada822 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -612,11 +612,11 @@ HTTP options:\n"),
> N_("\
> --post-data=STRING use the POST method; send STRING as the
> data.\n"),
> N_("\
> --post-file=FILE use the POST method; send contents of
> FILE.\n"),
> N_("\
> - --method=HTTPMethod use method \"HTTPMethod\" in the
> header.\n"),
> + --method=HTTPMethod use method \"HTTPMethod\" in the
> request.\n"),
> N_("\
> --body-data=STRING Send STRING as data. --method MUST be
> set.\n"),
> N_("\
> --body-file=FILE Send contents of FILE. --method MUST be
> set.\n"),
> N_("\
> --
> 2.0.1
>