Re: [Bug-wget] [PATCH] Using parallel test harness

[Tim Ruehsen]

Hi,

here is patch version #2.

- fixed some little scratches
- got rid of WgetTest.pm.in (WgetTest.pm now reads $top_srcdir from ENV).
- got rid of run-px

With these changes you can make use of TESTS_ENVIRONMENT variable, e.g.
        TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8" make check -j4

To run the tests with a turkish locale.
;-) Some tests break, but I am up to fix a few (e.g. the perl FTP server has a
locale issue which I already fixed - patch comes today).

> In my opinion, the two test suites should be kept separate, atleast for the
> time being while the new test suite is completed.

I agree. To keep it clean we shouldn't mix python and perl tests.

Thanks for your feedback, Darshit.

Tim

On Thursday 25 September 2014 14:53:44 Darshit Shah wrote:
> On Wed, Sep 24, 2014 at 04:45:59PM +0200, Tim Ruehsen wrote:
> > Hi,
> >
> > here is a first patch to enable the parallel test harness for the perl
> > tests.
> >
> > Please test and comment - i admit I have no older auto* environment to
> > test.
> Looks good! I have only the latest autotools for testing the patch, but I
> don't think this patch should create many issues. Of course, this feature
> was added only in autotools 1.11 I guess, so anything before that
> ./configure will fail. But since we've already used this feature in the
> Python based test suite, I don't think it's a problem any more.
>
> I ran the patch on both, master and parallel-wget without any errors.
>
> One thing this patch does is speed up the Perl-based test suite by a large
> extent and I'm really glad about it.
>
> > If you like it, we could get rid of tests/run-px (not used any more in my
> > patch). Also, we could easily merge the python test suite into the tests/
> > directory.
>
> Yes, I agree we can eliminate run-px completely. I don't see a use for that
> script anymore since you've integrated the tests to use the autotools
> harness.
>
> I'm not too sure about merging the Python tests into the tests/ directory.
> It would fix up the test and supporting files. The Python based tests
> require someone to volunteer to port the tests too. All the HTTP features
> are ready, only the tests are missing. FTP support is woefully lacking
> however and also the support for spawning multiple HTTP Servers for the
> parallel-wget branch's tests.
>
> In my opinion, the two test suites should be kept separate, atleast for the
> time being while the new test suite is completed.
>
> > Tim

0001-Switched-to-parallel-test-harness.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part.