Re: [Bug-wget] [PATCH] Using parallel test harness

[Tim Ruehsen]

On Tuesday 30 September 2014 21:52:01 Darshit Shah wrote:
> I was just going through your patch. Could you please add the *.trs and
> *.log entries to the .gitignore file? They would be listed under the
> Wildcards.

Done.

> About the fix for Test-proxied-https.px, I came across the following
> guideline
> in the Automake Tests manual:
> > Test programs that need data files should look for them in srcdir (which
> > is
> > both a make variable and an environment variable made available to the
> > tests), so that they work when building in a separate directory (see
> > Build Directories in The Autoconf Manual), and in particular for the
> > distcheck rule (see Checking the Distribution).

Done, using srcdir seems cleaner.

> I've been implementing a fix for testenv/ using abs_top_srcdir, but it seems
> we should be using $srcdir, maybe you can fix that?
>
> Also, the patch was generated against a slightly older git history, which is
> why it doesn't apply cleanly and fails on ChangeLog. Maybe you could run a
> git pull and then rebase your patch off the latest commit?

Done.

Tim

0001-Switched-to-parallel-test-harness.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part.