Re: [Bug-wget] [PATCH] Using parallel test harness

[Darshit Shah]

On 10/01, Tim Rühsen wrote:
> On Tuesday 30 September 2014 21:52:01 Darshit Shah wrote:
> > I was just going through your patch. Could you please add the *.trs and
> > *.log entries to the .gitignore file? They would be listed under the
> > Wildcards.
>
> Done.
>
> > About the fix for Test-proxied-https.px, I came across the following
> > guideline
> > in the Automake Tests manual:
> > > Test programs that need data files should look for them in srcdir (which
> > > is
> > > both a make variable and an environment variable made available to the
> > > tests), so that they work when building in a separate directory (see
> > > Build Directories in The Autoconf Manual), and in particular for the
> > > distcheck rule (see Checking the Distribution).
>
> Done, using srcdir seems cleaner.
>
> > I've been implementing a fix for testenv/ using abs_top_srcdir, but it seems
> > we should be using $srcdir, maybe you can fix that?
> >
> > Also, the patch was generated against a slightly older git history, which is
> > why it doesn't apply cleanly and fails on ChangeLog. Maybe you could run a
> > git pull and then rebase your patch off the latest commit?
>
> Done.
--- end quoted text ---

Hi Tim,

I saw the diff of the patch and it looked good. But, running it, I'm 
experiencing a lot of issues.

Test-proxied-https.px runs perfectly when executed directly but will *always* 
fail when executed through make check.
The print statement at line 18 in Test-proxied-https.px complains about an 
uninitialized variable when the test is executed directly.

The Test-iri* tests all fail, *always", when either executed directly or when 
make check is called from the tests/ directory. They execute successfully when 
make check is invoked from the root directory of the repository. Hence, I 
believe the issue lies in the test suite and not in Wget.

I've attached the files:
1. Test-proxied-https.px.log.direct: This was generated by directly executing 
  the test. The test passes without issue.
2. Test-proxied-https-auth.log: Autogenerated by make check. The test fails.
3. Test-iri.log: Generated by make check when executed from the tests/ dir. The 
  output is exactly the same as when attempting to directly execute the test.
4. Tests-iri.px.log.pass: This was generated when Test-iri.px is executed by 
  make check and the command was run from the project's root dir. It shows the 
  test was successful.

The Test-iri* files fail when executed from the tests/ directory even without 
the patch, but the issue with Test-proxied-https is definitely a regression

--
Thanking You,
Darshit Shah

Test-proxied-https.px.log.direct
Description: Text document

Test-proxied-https-auth.log
Description: Text document

Test-iri.log
Description: Text document

Test-iri.px.log.pass
Description: Text document

pgpxoWUCq48a1.pgp
Description: PGP signature