[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Using test filenames as default test name
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] Using test filenames as default test name |
Date: |
Thu, 02 Oct 2014 15:02:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Tim Ruehsen <address@hidden> writes:
> On Thursday 02 October 2014 13:07:09 Giuseppe Scrivano wrote:
>> Tim Ruehsen <address@hidden> writes:
>> > -my $the_test = HTTPTest->new (name =>
>> > "Test--spider-r-HTTP-Content-Disposition", +my $the_test = HTTPTest->new
>> > (
>> >
>> > input => \%urls,
>> > cmdline => $cmdline,
>> > errcode => $expected_error_code,
>>
>> I think it is a good idea and that we should just do it. The only minor
>> issue that I see is "my $the_test = HTTPTest->new (" on a line by
>> itself, we should drop the new line and have "input =>" on the same
>> line, like:
>>
>> my $the_test = HTTPTest->new (input => \%urls,
>>
>> this pattern repeats for all the tests.
>
> Ok, finally found a sed pattern:
> sed -i ':x; /HTTPTest->new ($/ { N; s/\n[[:space:]]*//; tx }' *.px
thanks for sharing it. It is always good to learn new sed tricks.
> Here is the amended patch.
I am going to push it soon.
Regards,
Giuseppe