[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-wget] Fixed python test suite to succeed distcheck
From: |
Tim Ruehsen |
Subject: |
[Bug-wget] Fixed python test suite to succeed distcheck |
Date: |
Thu, 02 Oct 2014 16:02:27 +0200 |
User-agent: |
KMail/4.14.1 (Linux/3.16-2-amd64; KDE/4.14.1; x86_64; ; ) |
Hi,
I felt free to fix / change the python test suite to succeed a 'make
distcheck'.
Please have a look at it and feel free to comment.
Darshit, I found the test suite chdir into a temp directory (testdir).
This is not the best idea, because you have to find e.g. the certs which is
only (or cleanly) possible through the 'srcdir' environment variable - which
is relative. This is why I had to use the hard-coded '..' in here:
# step one up because test suite change directory away from $srcdir (don't do
that !!!)
CERTFILE = os.path.abspath(os.path.join('..',os.getenv('srcdir','.'), 'certs',
'wget-cert.pem'))
I did not test if abs_srcdir is exported as well... (if not, we could export
it manually in Makefile.am/AM_TESTS_ENVIRONMENT).
So either we use abs_srcdir or you change the test code to not use chdir.
What do you think ?
Tim
0001-fixed-python-test-suite-to-succeed-distcheck.patch
Description: Text Data
signature.asc
Description: This is a digitally signed message part.
- [Bug-wget] Fixed python test suite to succeed distcheck,
Tim Ruehsen <=
- Re: [Bug-wget] Fixed python test suite to succeed distcheck, 'Darshit Shah', 2014/10/08
- Re: [Bug-wget] Fixed python test suite to succeed distcheck, Tim Ruehsen, 2014/10/08
- Re: [Bug-wget] Fixed python test suite to succeed distcheck, 'Darshit Shah', 2014/10/08
- Re: [Bug-wget] Fixed python test suite to succeed distcheck, Tim Rühsen, 2014/10/23
- Re: [Bug-wget] Fixed python test suite to succeed distcheck, Darshit Shah, 2014/10/23
- Re: [Bug-wget] Fixed python test suite to succeed distcheck, Tim Rühsen, 2014/10/23
- Re: [Bug-wget] Fixed python test suite to succeed distcheck, Darshit Shah, 2014/10/23