Re: [Bug-wget] [PATCH] Failing tests

[Tim Ruehsen]

On Thursday 02 October 2014 17:10:26 Tim Ruehsen wrote:
> Having a non "C" locale, Wget repeatable fails threee tests:
>
> FAIL: Test-iri.px
> FAIL: Test-iri-percent.px
> FAIL: Test-iri-forced-remote.px

...

> The iso-8859-15 URL should be de-percented, translated into UTF-8 and
> percent- encoded before putting it into the GET request line. Looks like
> this hasn't been done correctly.

Here is a patch with some fixes:

1. Wget mixed up the precedence of given charsets in http-equiv and header
Content-Type. The HTTP header Content-Type has priority (HTTP 1.0 and 1.1).

2. Wget did not correctly convert percent-encoded URLs to UTF-8. Before the
conversion via iconv() the URL has to be percent-decoded.

3. With 1. and 2. in mind, these tests had to be amended:
        tests/Test-iri.px
        tests/Test-idn-meta.px
        tests/Test-iri-forced-remote.px
        tests/Test-iri-percent.px

Reviews/comments are welcome.

@Darshit: Do you still encounter any random test failures ?

Tim

0001-fixed-IRI-misbehaviour-s.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part.